Fix #240 - cannot delete nodes with multiple graphs. #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ajbogh
commented
Aug 5, 2020
ajbogh
commented
ajbogh
commented
Aug 5, 2020
| @@ -425,7 +425,7 @@ class Edge extends React.Component<IEdgeProps> { | |||
| ) { | |||
| let response = Edge.getDefaultIntersectResponse(); | |||
|
|
|||
| if (trg[nodeKey] == null) { | |||
| if (trg == null || trg[nodeKey] == null) { | |||
There was a problem hiding this comment.
Fixes a minor console error that shows up when a node is deleted and the connected edges try to calculate their positions.
ajbogh
commented
Aug 5, 2020
| const timeoutId = `nodes-${nodeId}`; | ||
|
|
||
| // cancel an asyncRenderNode animation | ||
| cancelAnimationFrame(this.nodeTimeouts[timeoutId]); |
There was a problem hiding this comment.
This fixes the race condition bug by cancelling the asyncRenderNode method. Now nodes are deleted and stay deleted.
ajbogh
commented
Aug 5, 2020
| @@ -605,7 +612,7 @@ class GraphView extends React.Component<IGraphViewProps, IGraphViewState> { | |||
| } | |||
| }; | |||
|
|
|||
| handleEdgeSelected = e => { | |||
| handleEdgeSelected = (e: any) => { | |||
There was a problem hiding this comment.
Minor flowtype redline fix.
ajbogh
commented
Aug 5, 2020
| @@ -25,6 +25,7 @@ export type IEdgeType = IEdge; | |||
| export { default as GraphUtils } from './utilities/graph-util'; | |||
| export { default as Node } from './components/node'; | |||
| export type INodeType = INode; | |||
| // eslint-disable-next-line prettier/prettier | |||
There was a problem hiding this comment.
Fixes an annoying problem with prettier trying to fix the line breaks when it doesn't need to.
adriannesoike
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.