Fixed #219 of upstream. Can now render multiple graphs at the same time. #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiayenhung
reviewed
Jul 23, 2020
chiayenhung
approved these changes
Jul 25, 2020
ksnyder9801
approved these changes
Jul 27, 2020
ksnyder9801
approved these changes
Jul 27, 2020
| // Although it doesn't allow multiple graphs. | ||
| // We can use viewWrapperElem to scope the querySelector to a smaller set of elements to improve the speed | ||
| const nodeElem = viewWrapperElem.querySelector( | ||
| `[id='node-${trg[nodeKey]}']` |
There was a problem hiding this comment.
if we’re doing breaking changes, should we change ids to classes so we don’t need to use these workarounds for duplicate ids within the same document?
There was a problem hiding this comment.
Perhaps in the next PR we can address that. Please feel free to create a new PR after this if you want.
You are right that this will be a breaking change, so we have the opportunity to make a number of improvements.
| const graphControlsWrapper = this.viewWrapper.current.ownerDocument.getElementById( | ||
| 'react-digraph-graph-controls-wrapper' | ||
| const graphControlsWrapper = this.viewWrapper.current.querySelector( | ||
| '#react-digraph-graph-controls-wrapper' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should require a major version change due to breaking changes in the CSS for the zoom controls.