typings: initialBBox set to optional to match docs #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks @Vampiro. Can you please also change the graph-view-props.js file? This manages the Flowtypes which is what the typescript changes are based on. |
|
@ajbogh Done! Makes sense. |
|
Thanks again @Vampiro! I've merged the commit and will create a patch release on Monday. If you need it sooner, please let me know and I can get it ready. |
|
@ajbogh Monday will be just fine. Thank you much :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this project with Typescript and not sending in initialBBox as a prop to GraphView gives me a warning about it being required, but the README say it's not required and the code does a check before using it so I think it's safe to mark this as optional in the typings file.