Merge pull request #145 from uber/fix_getbbox_zoom

Fix 'Cannot read property 'getBBox' of null' error when remounting
uber · Jul 11, 2019 · b4219d3 · b4219d3
2 parents d2a28e0 + 40692f0
commit b4219d3
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/src/components/graph-view.js b/src/components/graph-view.js
@@ -221,7 +221,7 @@ class GraphView extends React.Component<IGraphViewProps, IGraphViewState> {
     // Manually render the first view.
     this.renderView();
     setTimeout(() => {
-      if (this.viewWrapper != null) {
+      if (this.viewWrapper.current != null) {
         this.handleZoomToFit();
       }
     }, zoomDelay);
@@ -1074,6 +1074,11 @@ class GraphView extends React.Component<IGraphViewProps, IGraphViewState> {
   // Zooms to contents of this.refs.entities
   handleZoomToFit = () => {
     const entities = d3.select(this.entities).node();
+
+    if (!entities) {
+      return;
+    }
+
     const viewBBox = entities.getBBox ? entities.getBBox() : null;
 
     if (!viewBBox) {
@@ -1084,6 +1089,10 @@ class GraphView extends React.Component<IGraphViewProps, IGraphViewState> {
   };
 
   handleZoomToFitImpl = (viewBBox: IBBox, zoomDur: number) => {
+    if (!this.viewWrapper.current) {
+      return;
+    }
+
     const parent = d3.select(this.viewWrapper.current).node();
     const width = parent.clientWidth;
     const height = parent.clientHeight;