Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMDSTAN_VERSION to 2.32.1 to resolve stan-dev/cmdstan#1158 #821

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

jeongyoonlee
Copy link
Collaborator

@jeongyoonlee jeongyoonlee commented Sep 25, 2023

Description

This PR fixes #822: Installation on M1 with the latest C++ compiler fails due to stan-dev/cmdstan#1158 because orbit uses cmdstan==2.31.0 in setup.py.

This PR updates CMDSTAN_VERSION to 2.32.1, which resolved the issue (ref).

Type of change

Please delete options that are not relevant.

  • Bug fix
  • New feature
  • Breaking change
  • This change requires a documentation update
  • Backend change such as github actions, travisCI etc.

How Has This Been Tested?

Copy link
Collaborator

@edwinnglabs edwinnglabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeongyoonlee jeongyoonlee merged commit 7919a8c into dev Sep 26, 2023
2 checks passed
@jeongyoonlee jeongyoonlee deleted the jeong/update_cmdstan_ver branch September 26, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation fails with LLVM libc++ version 16 on M1 Mac
2 participants