Switch standard way of publishing to maven + prepare to publish V0.52.4 #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kageiit
suggested changes
Jul 28, 2021
buildSrc/gradle.properties
Outdated
| @@ -0,0 +1,16 @@ | |||
| GROUP=com.uber | |||
| VERSION_NAME=0.52.4 | |||
| POM_DESCRIPTION=AGradle plugin that lets developers utilize the Buck build system on a Gradle project | |||
| @@ -41,6 +41,8 @@ def okbuck_android_module( | |||
| res_assets = None, | |||
| res_resource_union = None, | |||
| res_extra_deps = [], | |||
| res_deps = None, | |||
There was a problem hiding this comment.
Can you undo these changes or move them to a separate PR please?
| sign configurations.archives | ||
| } | ||
|
|
||
| if (project.getPlugins().hasPlugin('com.android.application') || |
There was a problem hiding this comment.
We probably dont want to publish the example projects so please make sure to mark those as not publishable. We only want to publish the plugin project
kageiit
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch standard way of publishing to maven + prepare to publish V0.52.4