Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy modes should be initiated #667

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Legacy modes should be initiated #667

wants to merge 1 commit into from

Conversation

kevinresol
Copy link

@kevinresol kevinresol commented Nov 19, 2021 •
edited
Loading

Because later when used the constructor test is not applied:

nebula.gl/modules/layers/src/layers/editable-geojson-layer.ts

Lines 316 to 318 in 81c8372

} else if (typeof props.mode === 'string') {
// Lookup the mode based on its name (for backwards compatibility)
mode = modeNameMapping[props.mode];

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@igorDykhta igorDykhta self-requested a review November 23, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorDykhta igorDykhta Awaiting requested review from igorDykhta

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinresol @CLAassistant