Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOMERGE Add/Replace ts-ignore with ts-expect-error #647

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

athomann
Copy link
Contributor

No description provided.

@athomann athomann changed the title Add/Replace ts-ignore with ts-expect-error NOMERGE Add/Replace ts-ignore with ts-expect-error Oct 15, 2021
"@deck.gl/layers": "^8.4.6",
"@deck.gl/mesh-layers": "^8.4.6",
"@deck.gl/react": "^8.4.6",
"@deck.gl/core": "^8.6.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you are bumping these, but ideally this should be done in a separate PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will separate out.

@@ -123,7 +123,7 @@ export function getEditHandleStyle({ feature, shape, index, state }) {

switch (shape) {
case 'circle':
//@ts-ignore
// @ts-ignore
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not expect-error here?

@@ -38,10 +38,10 @@ const styles = {
export default class Example extends React.Component<
{},
{
viewport: Object,
viewport: Record<string, any>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not your doing, but it seems strange to me that we have typescript syntax in .js files... Should these be renamed to .ts?

@@ -107,13 +113,16 @@ describe('dragToDraw=false', () => {
},
};

// @ts-expect-error ts-migrate(2304) FIXME: Cannot find name 'expect'.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot of expect-errors in the tests.... I don't think we should merge this.

Don't we just need to install some @types package for jest? Or worst case "hand write" a small .d.ts file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, a lot of this was automated. Adding @types/jest which will remove the need for these.

@ibgreen ibgreen requested a review from kargeor October 15, 2021 14:31
@ibgreen
Copy link
Collaborator

ibgreen commented Nov 17, 2021

@igorDykhta Can you rebase and land this?

@igorDykhta
Copy link
Collaborator

@igorDykhta Can you rebase and land this?

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants