Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to build on macOS 12 #233

Merged
merged 2 commits into from
May 1, 2023

Conversation

sidepelican
Copy link
Collaborator

To support building homebrew bottle on macOS 12, set swift-tools-version to 5.7.

(The latest Xcode that macOS11 can use is 13.2.1, and it is too old so I give up.

Copy link
Collaborator

@fummicc1 fummicc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think it might be better to update the description of system requirements in README, at the same time, though I shoud have mentioned this in the previous PR 🙏

@fummicc1 fummicc1 mentioned this pull request Apr 28, 2023
@sidepelican sidepelican merged commit 10241d1 into uber:master May 1, 2023
@sidepelican sidepelican deleted the macos12support branch May 1, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants