Use lib_InternalSwiftSyntaxParser resolved by SPM #223
Conversation
fummicc1
changed the title
install-script.sh
Outdated
| cp "$(xcode-select -p)"/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/macosx/lib_InternalSwiftSyntaxParser.dylib . | ||
| if [[ ! -e ./lib_InternalSwiftSyntaxParser.dylib ]]; then | ||
| echo "** Copy lib_InternalSwiftSyntaxParser.dylib from Xcode toolchain..." | ||
| cp "$(xcode-select -p)"/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/macosx/lib_InternalSwiftSyntaxParser.dylib . |
There was a problem hiding this comment.
Is this fallback necessary?
In almost all cases, this will not work and the original issue will be hidden.
This script should fail here.
There was a problem hiding this comment.
Thank you for your review.
Is this fallback necessary?
In my understanding, if swift version is under 5.6, lib_InternalSwiftSyntaxParser will not be prepared in resolving by SPM.
so in case user's swift environment is under swift 5.6, I didn't delete option to copy from xcode toolchain.
There was a problem hiding this comment.
In my understand, this script is used for distribution.
For legacy swift user, artifacts exist in release page. Also they can build mockolo theirself ( this is guaranteed by https://github.com/uber/mockolo/blob/master/.github/workflows/builds.yml )
Some escape hatches exist so not needs to consider backward compatibility I think.
There was a problem hiding this comment.
Ah, you are correct. install-script.sh is not an install option but distribution way.
I removed the fallback.
Overview
One of the install option; downloading mockolo.tar.gz does not work if we generate mockolo binary with
lib_InternalSwiftSyntaxParserwhich is placed inside Xcode toolchain.I think there is no need to copy
lib_internalSwiftSyntaxParser.dylibfrom xcode toolchain and we can just use one resolved by runningswift build.please feel free to correct me if there is a better way.
Issue