Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SwiftSyntax.TokenKind to determine a String is SwiftKeyword or not. #208

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

sidepelican
Copy link
Collaborator

extension is keyword of Swift, but it is not registered in String.SwiftKeywords so it doesn't be escaped.

In the new approach, use SwiftSyntax.TokenKind to determine a String is SwiftKeyword or not.

@uhooi uhooi self-requested a review November 22, 2022 09:48
Copy link
Collaborator

@uhooi uhooi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@uhooi uhooi merged commit 81292db into uber:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants