Accept integers to h3GetResolution #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfellis
approved these changes
Apr 29, 2021
nrabinowitz
reviewed
Apr 29, 2021
test/h3core.spec.js
Outdated
| test('h3GetResolution - integers', assert => { | ||
| // Same as in h3GetResolution above | ||
| const indexes = [ | ||
| [4294967295, 134389759], |
There was a problem hiding this comment.
Not required here, but I think we should probably expose h3IndexToSplitLong as a public function and use it here rather than hard-coding the input data. If this test fails, it'll be very hard for a future engineer to determine whether it's the fault of the code or the input.
nrabinowitz
reviewed
Apr 29, 2021
lib/h3core.js
Outdated
| ) { | ||
| const [lower, upper] = h3Index; | ||
| return H3.h3GetResolution(lower, upper); | ||
| } |
There was a problem hiding this comment.
Shouldn't we just delegate all paths to the C implementation here? i.e.
const [lower, upper] = h3IndexToSplitLong(h3Index);
return H3.h3GetResolution(lower, upper);
I'm not sure why we implemented it in pure JS at first, but I'm not convinced it's any faster.
There was a problem hiding this comment.
Yeah, I think it's best to use a similar optimization strategy to other bindings rather than relying on puling characters out. Using the library implementation seems more predictable.
nrabinowitz
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h3GetResolution had an unusual implementation that did not actually work for
H3IndexInputtype input. Fixed this and allow split integer input.