Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tensorflow optional #250

Closed
wants to merge 2 commits into from
Closed

Make tensorflow optional #250

wants to merge 2 commits into from

Conversation

maccam912
Copy link
Contributor

I am operating in a very low disk space environment, and Tensorflow as a dependency is giving me an extra 500 MB of download I don't need. I have moved it here to an optional extra, so a 'pip install causalml[tensorflow]' will still get it, but an installation of causalml without specifying tensorflow will only require xgboost.

All existing tests run when following CONTRIBUTING.md guidelines.

@ppstacy @paullo0106 @waltherg @jeongyoonlee @ccrndn @zhenyuz0500 and please tag anyone else I missed.

@maccam912
Copy link
Contributor Author

Related to issue #253

@jeongyoonlee
Copy link
Collaborator

Thanks for the PR, @maccam912! Although, it makes sense to exclude tensorflow in your use case, I am not sure about removing it from the default pip installation as this PR will do.

Instead, what about using --no-deps in your use case?

It'd be ideal if there's a way to exclude a certain dependency optionally ,but I couldn't find it.

Let me know what you think.

Thanks!

@jeongyoonlee jeongyoonlee added the installation Issues related to installation label Nov 18, 2020
@maccam912
Copy link
Contributor Author

You spend much more time with causalml than I do, so I defer to your judgement. I can close my PR, and try the --no-deps or use my fork if I need to use the reduced size download.

@maccam912 maccam912 closed this Nov 18, 2020
@jeongyoonlee
Copy link
Collaborator

Thanks. I'll look forward to more contribution from you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Issues related to installation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants