-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ListAllWorkflowExecutions method in frontend #6065
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits, but LGTM
}, | ||
) | ||
|
||
wh.GetLogger().Debug("List all workflows", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: not sure why this log is here.
I would expect if err != nil to be right after wh.GetVisibilityManager().ListAllWorkflowExecutions(
ctx context.Context, | ||
request *p.ListAllWorkflowExecutionsRequest, | ||
) (*p.ListWorkflowExecutionsResponse, error) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Should it be exempted from code coverage?
* Introduce ListAllWorkflowExecutions method in frontend * Update defs.go * fix lint issues * update tests
What changed?
ListAllWorkflowExecutions method in frontend api
Why?
To be able to list all workflow executions with partial search support
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes