Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set rate limit on Async APIs #5659

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Set rate limit on Async APIs #5659

merged 1 commit into from
Feb 14, 2024

Conversation

Shaddoll
Copy link
Contributor

What changed?

  • Introduce new dynamic configurations for rate limit of Async APIs
  • Set rate limit on Async APIs

Why?
To support new feature

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Feb 13, 2024

Pull Request Test Coverage Report for Build 018da521-ed71-4110-bde9-21ca4487d15b

Details

  • -2 of 15 (86.67%) changed or added relevant lines in 3 files are covered.
  • 60 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.03%) to 62.699%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/frontend/wrappers/ratelimited/ratelimit.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
common/persistence/sql/common.go 2 72.73%
common/persistence/sql/sqlplugin/mysql/db.go 2 83.33%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/task/parallel_task_processor.go 2 93.06%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
service/history/task/transfer_standby_task_executor.go 2 87.84%
service/matching/db.go 2 73.23%
common/log/tag/tags.go 3 50.46%
service/history/task/task_util.go 4 69.43%
common/task/fifo_task_scheduler.go 5 84.54%
Totals Coverage Status
Change from base Build 018da481-157b-4537-a670-44cb5f98ba41: 0.03%
Covered Lines: 92368
Relevant Lines: 147319

💛 - Coveralls

@Shaddoll Shaddoll enabled auto-merge (squash) February 14, 2024 01:01
@Shaddoll Shaddoll merged commit a78ee69 into uber:master Feb 14, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants