-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update run_cass_and_test.sh script to setup cassandra schemas #5628
Update run_cass_and_test.sh script to setup cassandra schemas #5628
Conversation
Pull Request Test Coverage Report for Build 018d4834-cc72-4295-8bbf-e495c1920cda
💛 - Coveralls |
Just be careful that this script doesn't propagate error codes properly (it needs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know that you can run tests locally with these docker compose?
https://github.com/uber/cadence/tree/master/docker/buildkite
@Shaddoll hmm missed that README file. tried it and fails during setup unzipping protoc. Are you using these commands successfully?
|
|
07cfd8c
to
87f39bc
Compare
What changed?
run_cass_and_test.sh
is creating a cassandra container and then running tests with CASSANDRA=1 env var.This wouldn't work if the cassandra db is not setup properly. e.g. creating keyspaces.
It was working for me locally because cassandra container was using previously populated data folder. Fresh installations or docker cleanup cause the script to not work.
So updating the script to also run
cadence:master-auto-setup
image which does db prep on startup.Note: I looked into using
docker/start.sh
instead of running the cadence container but didn't choose that path. It requirescqlsh
to be installed on local machine. I have correct version ofcqlsh
but it complains about some python packages missing. Better to just rely on already working setup on cadence:master-auto-setup.Follow up note: Some tests invoke
cqlsh
locally so not having a proper local cqlsh setup causes those to fail. Will come back to that issue because it's annoying. Might also ditch this script and fix the docker-compose based test invocation setup.