Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Checker Framework 3.43.0 #959

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented May 20, 2024

The previous bug that was preventing us from upgrading (typetools/checker-framework#6396) is fixed in this release. Benchmarks show no performance regression.

@msridhar
Copy link
Collaborator Author

/benchmark

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.12%. Comparing base (e26e194) to head (49333ad).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #959   +/-   ##
=========================================
  Coverage     86.12%   86.12%           
  Complexity     2040     2040           
=========================================
  Files            81       81           
  Lines          6708     6708           
  Branches       1293     1293           
=========================================
  Hits           5777     5777           
  Misses          518      518           
  Partials        413      413           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Main Branch:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25   9.258 ± 0.098  ops/s
CaffeineBenchmark.compile         thrpt   25   2.135 ± 0.019  ops/s
DFlowMicroBenchmark.compile       thrpt   25  24.858 ± 0.248  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.278 ± 0.018  ops/s

With This PR:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25   9.216 ± 0.068  ops/s
CaffeineBenchmark.compile         thrpt   25   2.131 ± 0.013  ops/s
DFlowMicroBenchmark.compile       thrpt   25  24.902 ± 0.259  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.262 ± 0.028  ops/s

@msridhar msridhar marked this pull request as ready for review May 20, 2024 18:59
@msridhar msridhar requested review from lazaroclapp and yuxincs May 20, 2024 19:00
@msridhar msridhar merged commit 5d3e264 into uber:master May 20, 2024
12 checks passed
@msridhar msridhar deleted the cf-3.43.0 branch May 20, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants