Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Checker Framework dependence to 3.38.0 #819

Merged
merged 6 commits into from
Sep 1, 2023
Merged

Bump Checker Framework dependence to 3.38.0 #819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dcb52e5
WIP
msridhar Aug 12, 2023
7cbdf62
Merge branch 'master' into bump-dataflow-to-3.37.0
msridhar Aug 26, 2023
527f749
WIP
msridhar Aug 26, 2023
ef21dd6
Merge branch 'master' into bump-checker-framework
msridhar Sep 1, 2023
a6afe84
3.38.0
msridhar Sep 1, 2023
a68660e
Merge branch 'master' into bump-checker-framework
msridhar Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/dependencies.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ if (project.hasProperty("epApiVersion")) {

def versions = [
asm : "9.3",
checkerFramework : "3.26.0",
checkerFramework : "3.38.0",
// for comparisons in other parts of the build
errorProneLatest : latestErrorProneVersion,
// The version of Error Prone used to check NullAway's code.
Expand Down
16 changes: 8 additions & 8 deletions nullaway/src/main/java/com/uber/nullaway/dataflow/AccessPathNullnessPropagation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
import org.checkerframework.nullaway.dataflow.cfg.node.DoubleLiteralNode;
import org.checkerframework.nullaway.dataflow.cfg.node.EqualToNode;
import org.checkerframework.nullaway.dataflow.cfg.node.ExplicitThisNode;
import org.checkerframework.nullaway.dataflow.cfg.node.ExpressionStatementNode;
import org.checkerframework.nullaway.dataflow.cfg.node.FieldAccessNode;
import org.checkerframework.nullaway.dataflow.cfg.node.FloatLiteralNode;
import org.checkerframework.nullaway.dataflow.cfg.node.FloatingDivisionNode;
Expand Down Expand Up @@ -113,7 +114,6 @@
import org.checkerframework.nullaway.dataflow.cfg.node.ReturnNode;
import org.checkerframework.nullaway.dataflow.cfg.node.ShortLiteralNode;
import org.checkerframework.nullaway.dataflow.cfg.node.SignedRightShiftNode;
import org.checkerframework.nullaway.dataflow.cfg.node.StringConcatenateAssignmentNode;
import org.checkerframework.nullaway.dataflow.cfg.node.StringConcatenateNode;
import org.checkerframework.nullaway.dataflow.cfg.node.StringConversionNode;
import org.checkerframework.nullaway.dataflow.cfg.node.StringLiteralNode;
Expand Down Expand Up @@ -376,13 +376,6 @@ public TransferResult<Nullness, NullnessStore> visitBitwiseXor(
return noStoreChanges(NONNULL, input);
}

@Override
public TransferResult<Nullness, NullnessStore> visitStringConcatenateAssignment(
StringConcatenateAssignmentNode stringConcatenateAssignmentNode,
TransferInput<Nullness, NullnessStore> input) {
return noStoreChanges(NULLABLE, input);
}

@Override
public TransferResult<Nullness, NullnessStore> visitLessThan(
LessThanNode lessThanNode, TransferInput<Nullness, NullnessStore> input) {
Expand Down Expand Up @@ -1085,6 +1078,13 @@ public TransferResult<Nullness, NullnessStore> visitClassDeclaration(
return noStoreChanges(NULLABLE, input);
}

@Override
public TransferResult<Nullness, NullnessStore> visitExpressionStatement(
ExpressionStatementNode expressionStatementNode,
TransferInput<Nullness, NullnessStore> input) {
return noStoreChanges(NULLABLE, input);
}

@Override
public TransferResult<Nullness, NullnessStore> visitPackageName(
PackageNameNode packageNameNode, TransferInput<Nullness, NullnessStore> input) {
Expand Down
2 changes: 1 addition & 1 deletion nullaway/src/main/java/com/uber/nullaway/dataflow/cfg/NullAwayCFGBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ public <R, D> R accept(TreeVisitor<R, D> visitor, D data) {
}
},
booleanExpressionNode,
this.getProcessingEnvironment().getTypeUtils()),
this.env.getTypeUtils()),
errorType);
exNode.setTerminatesExecution(true);
this.addLabelForNextNode(endPrecondition);
Expand Down