Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gradle maven publish plugin from 0.21.0 to 0.25.3 #810

Merged
merged 10 commits into from
Aug 22, 2023

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Aug 18, 2023

Changelog for plugin

We have to do some renaming as the javaSourcesJar configuration is now just sourcesJar. Also, the :nullaway:buildWithNullAway previously used a hacky way to refer to the current NullAway jar that broke with this upgrade. Here we clean things up to refer to the current jar more directly.

The plugin has better integration with Sonatype and will close the staging repository after all artifacts are uploaded. There is an option to automatically release as well, but I haven't enabled that for now (it makes testing of release uploads difficult), so you still need to go to https://oss.sonatype.org to finalize the release. Relatedly, apparently we don't need --no-daemon and --no-parallel flags anymore when cutting a release; updated the release docs accordingly.

I tested locally and confirmed that the exact same number of files get included in the jar-infer-cli shadow jar, and that cutting a real release successfully uploads to Maven Central.

@msridhar msridhar changed the title Bump gradle maven publish plugin to 0.25.3 Bump gradle maven publish plugin from 0.21.0 to 0.25.3 Aug 19, 2023
@msridhar msridhar marked this pull request as ready for review August 19, 2023 02:14
Copy link
Collaborator

@lazaroclapp lazaroclapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msridhar msridhar enabled auto-merge (squash) August 22, 2023 04:12
@msridhar msridhar merged commit e05fd9a into uber:master Aug 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants