Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump versions for some dependencies #800

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Bump versions for some dependencies #800

merged 1 commit into from
Aug 11, 2023

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Aug 5, 2023 •
edited
Loading

To keep up to date and avoid surprises later.

@msridhar
Copy link
Collaborator Author

msridhar commented Aug 5, 2023

/benchmark

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

Main Branch:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25   9.148 ± 0.030  ops/s
CaffeineBenchmark.compile         thrpt   25   2.116 ± 0.014  ops/s
DFlowMicroBenchmark.compile       thrpt   25  24.772 ± 0.335  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.276 ± 0.013  ops/s

With This PR:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25   9.214 ± 0.072  ops/s
CaffeineBenchmark.compile         thrpt   25   2.102 ± 0.016  ops/s
DFlowMicroBenchmark.compile       thrpt   25  25.077 ± 0.218  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.284 ± 0.017  ops/s

@msridhar msridhar changed the title [WIP] Bump versions for some dependencies Bump versions for some dependencies Aug 10, 2023
@msridhar msridhar marked this pull request as ready for review August 10, 2023 23:49
msridhar
msridhar commented Aug 10, 2023
View reviewed changes
build.gradle
id "com.github.kt3k.coveralls" version "2.12.0" apply false
id "me.champeau.jmh" version "0.6.8" apply false
id "com.github.ben-manes.versions" version "0.42.0"
id "me.champeau.jmh" version "0.7.1" apply false
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed via our CI support that benchmarking still works after this change.

lazaroclapp
lazaroclapp approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@lazaroclapp lazaroclapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msridhar msridhar merged commit f14b43d into uber:master Aug 11, 2023
7 checks passed
@msridhar msridhar deleted the bump-some-deps branch August 11, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazaroclapp lazaroclapp lazaroclapp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msridhar @lazaroclapp