Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing source files in android-jarinfer-models-sdk modules #1033

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Sep 7, 2024

These are copied from the sdk28 module. These are needed in order for the models to be loaded by the code here.

I am deliberately not adding an integration test to detect this issue right now, though I think we could using the Android sample app. The issue is that we are currently evolving the astubx format, and I don't want to be forced to re-generate these SDK models astubx files each time we make a small change. I'll open an issue so that we add the integration test once our work on astubx stabilizes and before we cut our next release.

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.23%. Comparing base (e2e5394) to head (f85cd97).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1033   +/-   ##
=========================================
  Coverage     87.23%   87.23%           
  Complexity     2129     2129           
=========================================
  Files            83       83           
  Lines          6965     6965           
  Branches       1356     1356           
=========================================
  Hits           6076     6076           
  Misses          458      458           
  Partials        431      431           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar merged commit ee23831 into uber:master Sep 10, 2024
11 checks passed
@msridhar msridhar deleted the fix-missing-sdk-source-file branch September 10, 2024 04:23
msridhar added a commit to msridhar/NullAway that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants