Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop a policy for how long we support Error Prone versions #882

Open
msridhar opened this issue Dec 20, 2023 · 0 comments
Open

Develop a policy for how long we support Error Prone versions #882

msridhar opened this issue Dec 20, 2023 · 0 comments

Comments

@msridhar
Copy link
Collaborator

We should develop a policy for how long we plan to support old Error Prone versions, and then somehow track in a more organized way what code cleanup can be done once we drop support for older versions (right now it's done in code comments but it can be hard to find).

msridhar added a commit that referenced this issue May 31, 2024
This PR drops support for running NullAway on a JDK 8 JVM. After it
lands, running NullAway will require JDK 11 or above (like current
versions of Error Prone). There are various cleanups that this change
enables, but to keep the PR small, I tried to do close to the minimum.
In particular:

* I updated the minimum supported Error Prone version to 2.14.0, which
is ~2 years old. Depending on what we decide about policy (see #882) we
may want to bump this to an even more recent version.
* Update our JDK 8 test tasks to instead just test building with the
most recent supported Error Prone version but running on the oldest
supported version. I tested locally that this does still detect binary
compatibility issues.
* Remove references to Java 11 in the jarinfer build files, as we now
use that version everywhere.

We will have to change the required CI job names before landing this. 

Will do other enabled cleanups in separate PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant