Skip to content

Commit

Permalink
Fix: android-jar.py's exit code. (#399)
Browse files Browse the repository at this point in the history
This script would not propagate the exit code from
the final call to jarinfer, leading it to potentially
return success even when jarinfer fails to run.

This is not critical, since this script is only used for
the release process and other steps will fail before publishing
to maven central. Still worth fixing, though.

Credit to Clint Gibler, R2C, and the semgrep tool for finding
this.
  • Loading branch information
lazaroclapp authored Jun 18, 2020
1 parent bbc790f commit c1d0737
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion jar-infer/scripts/android-jar.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,5 @@
if options.verbose:
cmd += " -dv"
print cmd
subprocess.call(cmd, shell=True)
returncode = subprocess.call(cmd, shell=True)
sys.exit(returncode)

0 comments on commit c1d0737

Please sign in to comment.