lint lenient mode support kotlin lambda/when/if expressions #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ZacSweers
approved these changes
Apr 22, 2022
|
This is great, thanks! Apologies for the delay in looking, I missed this PR |
|
Looks like this just needs a |
1cd69cc |
ZacSweers
approved these changes
May 7, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
if lint lenient mode enabled, unused disposable in kotlin lambda/when/if expressions should be checked.
So this PR change behavior of
AutoDisposeDetector::isExpressionValueUnusedto support checking reactive expressions in kotlin lambda/when/if expressions used or not.Luckily, up-to-date origin reference of function
isExpressionValueUnusedfunction support these expressions, so i just update source code from origin and add some testcasesRelated issue(s): #465