Improve RxJava versions support documentation #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Could you add an after screenshot and sign the CLA? |
|
@ZacSweers Updated description with before & after. |
ZacSweers
approved these changes
Feb 22, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This improves the readability of the RxJava versions support section of the documentation by displaying the version mapping as a table. Also, when rendered to GitHub Pages, the sub bullet indentations don't seem to be translating...
Before:
When reading this it didn't cross my mind initially that this was basically a compatibility matrix until I tried to use AutoDispose 2.x with RxJava 2.x and re-read the documentation.
After:
Related issue(s): N/A