Add zaptest logger option to wrap zap.Option's #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #610 +/- ##
==========================================
+ Coverage 97.23% 97.38% +0.14%
==========================================
Files 40 40
Lines 2063 2102 +39
==========================================
+ Hits 2006 2047 +41
+ Misses 49 47 -2
Partials 8 8
Continue to review full report at Codecov.
|
akshayjshah
suggested changes
Jul 31, 2018
There was a problem hiding this comment.
Thanks for the PR, @iaroslav-ciupin! This feature would be great. However, I'd rather not replicate each of the core zap package's options. Instead, I'd rather have the zaptest package provide a generic adapter for the base options:
- The
loggerOptionsstruct should have a field ofzap.Options. - Add a function that converts any number of
zap.Options to a singlezaptest.Option:
func WrapOptions(opts ...zap.Option) LoggerOption { ...implementation...}
- In
NewLogger, we'd pass all the options on theloggerOptionsstruct tozap.New.
iaroslav-ciupin
changed the title
|
@akshayjshah Thank you for your reply! I've adjusted PR and proposal accordingly. Please have a look ;) |
cgxxv
pushed a commit
to cgxxv/zap
that referenced
this pull request
Mar 25, 2022
Add a wrapper that converts any `zap.Option` into a `zaptest.LoggerOption`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
This PR adds feature suggested in #609