Enable lint on go1.7 #135
Merged
Enable lint on go1.7 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,6 +33,8 @@ else | |||
| @echo "Not installing golint, since we don't expect to lint on" $(GO_VERSION) | |||
| endif | |||
|
|
|||
| VET_SKIP_ERRORF=grep -v -e "possible formatting directive in Error call" | |||
There was a problem hiding this comment.
Is this a pervasive issue in zap, or is there one particular place where vet complains?
There was a problem hiding this comment.
calls to testify's assert.Error, which i guess i can just rewrite.
|
We should keep the checks as It seems to only happen if the vendor directory is available: $ go tool vet flag_test.go
flag_test.go:61: possible formatting directive in Error call
$ mv vendor vendor_
$ go tool vet flag_test.go
$ mv vendor_ vendor
$ go tool vet flag_test.go
flag_test.go:61: possible formatting directive in Error callIt looks like if the type is available, |
|
Should we disable the printf checks when running vet for now? |
|
lgtm, can you add a comment to why we disabled printf checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.