Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on github.com/pkg/errors #1255

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

ILLU510N
Copy link
Contributor

close #1218
Remove dependency on error unit testing. Remove go mod dependency.

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Merging #1255 (9f7b9a3) into master (384e782) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1255      +/-   ##
==========================================
- Coverage   98.23%   98.08%   -0.16%     
==========================================
  Files          49       49              
  Lines        3231     3231              
==========================================
- Hits         3174     3169       -5     
- Misses         49       53       +4     
- Partials        8        9       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@sywhang sywhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the contribution.

cc @mway @abhinav

Copy link
Member

@mway mway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mway mway merged commit 05c4b6c into uber-go:master Mar 20, 2023
@ILLU510N ILLU510N deleted the rm-pkg-errors branch March 20, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on github.com/pkg/errors
4 participants