-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new x/tools dep to work with newer go1.23.0 #270
Conversation
I experience the same problem and this fixes it for me as well. |
@jayalane , would you mind signing the CLA? Happy to merge the PR once CLA is signed 😃 Thank you for the contributions! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
=======================================
Coverage 87.60% 87.60%
=======================================
Files 63 63
Lines 7916 7916
=======================================
Hits 6935 6935
Misses 799 799
Partials 182 182 ☔ View full report in Codecov by Sentry. |
Signed. (I had signed it at the time but I put in a different email that I thought was associated to the account but wasn't; just now I signed it with an email that was associated to the account). |
The failing test looks like it succeeded but then failed to connect back to api.github.com with the results. 403. a |
Yeah it's because the |
Thanks @jayalane! |
As per issue #269 this PR updates go.mod/go.sum to work with go 1.23.0