Cleanup, and fix failing test

uber-go · Dec 14, 2017 · 483d6c9 · 483d6c9
1 parent 39532e9
commit 483d6c9
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/entity_parser.go b/entity_parser.go
@@ -395,13 +395,13 @@ func parensBalanced(s string) bool {
 	var ssize uint
 	for i := 0; i < len(s); i++ {
 		if s[i] == '(' {
-			ssize += 1
+			ssize++
 		} else if s[i] == ')' {
 			if ssize == 0 {
 				// Extra right paren
 				return false
 			}
-			ssize -= 1
+			ssize--
 		}
 	}
 	// Stack must be empty

diff --git a/entity_parser_test.go b/entity_parser_test.go
@@ -513,12 +513,12 @@ func TestParensBalanced(t *testing.T) {
 	assert.True(t, parensBalanced(""))
 	assert.True(t, parensBalanced("()(()(()(()()))())()()"))
 
-	assert.True(t, !parensBalanced("("))
-	assert.True(t, !parensBalanced(")"))
-	assert.True(t, !parensBalanced("(()"))
-	assert.True(t, !parensBalanced(")("))
-	assert.True(t, !parensBalanced("(()))"))
-	assert.True(t, !parensBalanced("((()())"))
+	assert.False(t, parensBalanced("("))
+	assert.False(t, parensBalanced(")"))
+	assert.False(t, parensBalanced("(()"))
+	assert.False(t, parensBalanced(")("))
+	assert.False(t, parensBalanced("(()))"))
+	assert.False(t, parensBalanced("((()())"))
 }
 
 /*

diff --git a/finder_test.go b/finder_test.go
@@ -80,7 +80,7 @@ func TestParser(t *testing.T) {
 
 	assert.Equal(t, len(expectedEntities)+len(entitiesExcludedForTest), len(entities), fmt.Sprintf("%s", entities))
 	// TODO(jzhan): remove the hard-coded number of errors.
-	assert.Equal(t, 21, len(errs), fmt.Sprintf("%v", errs))
+	assert.Equal(t, 22, len(errs), fmt.Sprintf("%v", errs))
 	assert.Nil(t, err)
 
 	for _, entity := range entities {