tools: Move to a submodule #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renaming tools.go to tools_test.go isn't enough. These constraints are still carried over to consumers. Renaming only drops them from `go mod vendor`. This moves tools dependencies to a `tools` submodule which we will never publish. Ref uber-go/multierr#38
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 239 239
=========================================
Hits 239 239 Continue to review full report at Codecov.
|
prashantv
approved these changes
Sep 11, 2020
| @@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ### Changed | |||
| - Disallow incorrect comparison of atomic values in a non-atomic way. | |||
|
|
|||
| ### Removed | |||
| - Remove dependency on `golang.org/x/{lint, tools}`. | |||
There was a problem hiding this comment.
or maybe just Moved out test dependencies (since it doesn't affect module resolution etc, just go mod download)
There was a problem hiding this comment.
We're not dropping all test dependencies, though. Only dev-time dependencies.
abhinav
added a commit
to uber-go/automaxprocs
that referenced
this pull request
Jan 29, 2021
Move lint dependencies to a tools submodule so that these are not introduced as dependencies of the package. In other projects, we experimented with renaming `tools.go` to `tools_test.go` but that wasn't enough either. The tools submodule appears to be the safest approach. Supersedes #32 Refs uber-go/atomic#78
abhinav
added a commit
to uber-go/automaxprocs
that referenced
this pull request
Jan 29, 2021
Move lint dependencies to a tools submodule so that these are not introduced as dependencies of the package. In other projects, we experimented with renaming `tools.go` to `tools_test.go` but that wasn't enough either. The tools submodule appears to be the safest approach. Supersedes #32 Refs uber-go/atomic#78
abhinav
added a commit
to uber-go/automaxprocs
that referenced
this pull request
Feb 1, 2021
Move lint dependencies to a tools submodule so that these are not introduced as dependencies of the package. In other projects, we experimented with renaming `tools.go` to `tools_test.go` but that wasn't enough either. The tools submodule appears to be the safest approach. Supersedes #32 Refs uber-go/atomic#78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming tools.go to tools_test.go isn't enough. These constraints are
still carried over to consumers. Renaming only drops them from
go mod vendor.This moves tools dependencies to a
toolssubmodule which we will neverpublish.
Ref uber-go/multierr#38