Changes to accompany issues found in OSG modifications #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o NULL instead of 0
smgallo
added
enhancement
plessbd
approved these changes
Apr 5, 2017
tyearke
reviewed
Apr 5, 2017
tools/dev/verify_table_data.php
Outdated
| LEFT OUTER JOIN $destTableName dest ON (" . join(' AND ', $constraints) . ")" | ||
| . ( 0 != count($where) ? "\nWHERE " . implode(' AND ', $where) : "" ) | ||
| LEFT OUTER JOIN $destTableName dest ON (" . join("\nAND ", $constraints) . ")" | ||
| . ( 0 != count($where) ? "\nWHERE " . implode("\nAND", $where) : "" ) |
There was a problem hiding this comment.
The lack of whitespace after AND could cause problems.
tools/dev/verify_table_data.php
Outdated
| @@ -541,7 +541,7 @@ function usage_and_exit($msg = null) | |||
| -n, --num-missing-rows <number_of_rows> | |||
| Display this number of missing rows. If not specified, all missing rows are displayed. | |||
|
|
|||
| -r, --round-column <column>[=<digits>] | |||
| -r, --round-column <column>[,<digits>] | |||
There was a problem hiding this comment.
The indentation of this line is a little funky.
ryanrath
pushed a commit
to ryanrath/xdmod
that referenced
this pull request
Apr 27, 2017
Table Verifier: * Added --ignore-column-count to only compare columns that exist in the source table * Add ability to round columns before comparing * Added ability to ignore column types in comparison ETLv2: * Improved log formatting * Catch error when FROM table does not exist yet * Change squared colum type to decimal(36,4) and default waitduration to NULL instead of 0 in HPC Jobs aggregator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to accompany issues found in OSG modifications
See ubccr/xdmod-xsede#23
Description
The aggregation query for job records and tasks now uses a datatype of
DECIMAL(36,4)rather thanDOUBLEfor thesum_wallduration_squared,sum_waitduration_squared,sum_cpu_time_squared,sum_local_charge_xdsu_squared, andsum_node_time_squaredcolumns. The waitduration has been defaulted toNULLto support cases when we do not have this information (e.g., OSG).Several enhancements to the table comparison tool were made:
doubletodecimal(m,n)Motivation and Context
When comparing new data as the result of a change to baseline data it is helpful to use the
DECIMAL(M,N)data type rather thanDOUBLEwhich may use approximate representation of floating point numbers. This makes data verification much easier.Tests performed
The XSEDE job pipeline was run before and after changes to the aggregation query. Running the table verificaiton tool, data was identical with the exception of cases where the baseline used an approximate representation of the data (e.g.,
4.1038701667445064e16). In these cases the squared values were off by up to .00000000000000017%Types of changes
Checklist: