Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate asset html tags #82

Merged
merged 2 commits into from
Apr 4, 2017

Conversation

jtpalmer
Copy link
Contributor

@jtpalmer jtpalmer commented Apr 3, 2017

Description

Generate JavaScript and CSS HTML tags for modules from configuration files.

Also removes allocations CSS file, moved to XSEDE repo in corresponding PR.

See ubccr/xdmod-appkernels#14 and ubccr/xdmod-xsede#22

Motivation and Context

Moves module logic and configuration from the base XDMoD package into the corresponding modules. Changes to modules should not require changes to the base package.

Tests performed

Installed package and checked HTML for the correct tags. Still needs more testing to make sure there are no issues with the new placement of the tags.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added the enhancement Enhancement of the functionality of an existing feature label Apr 3, 2017
@jtpalmer jtpalmer added this to the v6.6.0 milestone Apr 3, 2017
@jtpalmer jtpalmer merged commit 4b606aa into ubccr:xdmod6.6 Apr 4, 2017
@jtpalmer jtpalmer deleted the generate-asset-html-tags branch April 4, 2017 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants