Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support asynchronous loading of Usage tab thumbnail charts #750

Merged
merged 3 commits into from
Dec 20, 2018
Merged

Support asynchronous loading of Usage tab thumbnail charts #750

merged 3 commits into from
Dec 20, 2018

Commits on Dec 19, 2018

  1. Style fixes

    @jpwhite4
    jpwhite4 committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    0c000d4 View commit details
    Browse the repository at this point in the history

  2. Summary view in Usage Tab loads charts async

    @jpwhite4
    jpwhite4 committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    6df1e7d View commit details
    Browse the repository at this point in the history

  3. Updates as per jpwhite4 code review 

    There is no need to set a storeId since the store is not referenced elsewhere. Setting
the storeId results in the store being registered with the store manager and will
interfere with the garbage collector
    @jpwhite4
    jpwhite4 committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    6357f35 View commit details
    Browse the repository at this point in the history