Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Job Viewer API to support multiple realms #733

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Update Job Viewer API to support multiple realms #733

merged 1 commit into from
Nov 28, 2018

Conversation

jpwhite4
Copy link
Member

Description

This change updates the internal API for the job viewer. The is a corresponding pull request
for the supremm realm updates.

Motivation and Context

API updates to make it easier to support multiple realms in the job viewer. The changes are as follows:

  • Add interface class that documents the job metadata API
  • Change the JobDataset API to remove the realm-specific knowledge for primary key and 'Quick Lookup' searches of the database. The realm-specific code is moved to the realm-specific implementation.
  • Remove the numeric-only constraint for local job id from the 'Quick Lookup' search on the front end. This realm-specific constraint is now managed in the realm-specific code.
  • Remove the "singlejobviewer" configuration parameter from the portal_settings file. The job viewer is now automatically enabled if there is an installed realm that uses it.

@jpwhite4 jpwhite4 mentioned this pull request Nov 27, 2018
Closed
@jpwhite4 jpwhite4 merged commit 4fbe1e1 into ubccr:xdmod8.1 Nov 28, 2018
@jpwhite4 jpwhite4 deleted the raw_data_api_updates branch November 28, 2018 16:51
This was referenced Nov 28, 2018
Closed
Closed
Closed
jpwhite4 added a commit to jpwhite4/xdmod that referenced this pull request Jan 16, 2019
@jpwhite4
Fix Job Viewer deep link regression (introduced in ubccr#733).
727f56f 
The Update Job Viewer API ubccr#733 pull request introduced check to confirm
that the jobref is an int. This check was too restrictive since the
jobref will be a numeric string when loading from a url.
jpwhite4 added a commit to jpwhite4/xdmod that referenced this pull request Jan 16, 2019
@jpwhite4
Fix Job Viewer deep link regression (introduced in ubccr#733).
8a74ab4 
The Update Job Viewer API ubccr#733 pull request introduced check to confirm
that the jobref is an int. This check was too restrictive since the
jobref will be a numeric string when loading from a url.
@jpwhite4 jpwhite4 mentioned this pull request Jan 16, 2019
Merged
jpwhite4 added a commit to ubccr/xdmod-supremm that referenced this pull request Feb 8, 2019
@jpwhite4
Merge pull request #144 from jpwhite4/framework_updates
95ddf06 
Updates to CI tests needed by ubccr/xdmod#733 and ubccr/xdmod#781
jpwhite4 added a commit that referenced this pull request Feb 14, 2019
@jpwhite4
Merge pull request #777 from jpwhite4/fix_jobviewer_deeplink
156d4c1 
Fix Job Viewer deep link regression (introduced in #733).
jtpalmer pushed a commit to jtpalmer/xdmod that referenced this pull request Feb 15, 2019
@jpwhite4 @jtpalmer
Fix Job Viewer deep link regression (introduced in ubccr#733).
4f46b71 
The Update Job Viewer API ubccr#733 pull request introduced check to confirm
that the jobref is an int. This check was too restrictive since the
jobref will be a numeric string when loading from a url.
@plessbd plessbd added the enhancement Enhancement of the functionality of an existing feature label Feb 18, 2019
@plessbd plessbd added this to the 8.1.0 milestone Feb 18, 2019
jpwhite4 added a commit to jpwhite4/xdmod that referenced this pull request Mar 1, 2019
@jpwhite4
Fix regression in getJobDataSet introduced in ubccr#733
7041e5e 
This change was incorrectly ommited in ubccr#733.
@jpwhite4 jpwhite4 mentioned this pull request Mar 1, 2019
Merged
jpwhite4 added a commit that referenced this pull request Mar 1, 2019
@jpwhite4
Merge pull request #834 from jpwhite4/rest_bugfix
b1363cb 
Fix regression in getJobDataSet introduced in #733
jtpalmer pushed a commit to jtpalmer/xdmod that referenced this pull request Mar 11, 2019
@jpwhite4 @jtpalmer
Fix regression in getJobDataSet introduced in ubccr#733
f143d1d 
This change was incorrectly ommited in ubccr#733.
@smgallo smgallo changed the title Update Job Viewer API Update Job Viewer API to support multiple realms Apr 10, 2019
@smgallo smgallo added the Category:Job Viewer Job Viewer label Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plessbd plessbd plessbd approved these changes

Assignees
No one assigned
Labels
Category:Job Viewer Job Viewer enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jpwhite4 @plessbd @smgallo