Improve verification of resource codes #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smgallo
force-pushed
the
catch-unknown-resource-code
branch
from
a528242
to
d462d9a
Compare
plessbd
previously approved these changes
Nov 7, 2018
smgallo
force-pushed
the
catch-unknown-resource-code
branch
from
d462d9a
to
5ed5166
Compare
eiffel777
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Invalid resource codes were not properly caught when populating the
${RESOURCE_ID}in an action's variable store. Resource codes are now verified as part of the action verification if they were specified on theetl_overseercommand line (or passed directly toEtlConfiguration) or in an ETL configuration file.Motivation and Context
Bugfix.
Tests performed
Added new tests.
Types of changes
Checklist: