Added PHP dependancies to README #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XDMoD requires two additional PHP deps to build
tyearke
reviewed
Mar 31, 2017
There was a problem hiding this comment.
Thank you for bringing this to our attention and submitting a pull request! Your proposed solution looks good - I'd just like to ask that the Ubuntu-specific notes specify Ubuntu 16.04 and that the package names both use either php- or php7.0- for consistency.
Otherwise, LGTM. 👍
|
Hi @Samathy, Because we're preparing for a release, I've gone ahead and made the requested tweaks. Your original commit will be preserved in the repo, as we'd like for you to still get credit for bringing this to our attention and providing a fix. Thank you again for your contribution! |
plessbd
approved these changes
Apr 12, 2017
|
Hey guys, Sorry for the lack in communication - busy couple of weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XDMoD requires two additional PHP deps to build
These deps are required to build on Ubuntu.
Until those deps are pulled in by one of the build tools, we should specify those in the README.