Allow search panel scroll bars on small displays #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpalmer
approved these changes
Oct 15, 2018
| @@ -65,6 +65,7 @@ XDMoD.Module.JobViewer.SearchPanel = Ext.extend(Ext.Panel, { | |||
| Ext.apply(this, { | |||
| layout: 'table', | |||
| width: 1000, | |||
| autoScroll: true, | |||
There was a problem hiding this comment.
Indentation looks odd here, but I'm guessing this is the correct indentation and everything else is wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The job viewer search panel is hardcoded to ~1000 x 600 px and cannot be resized and scrollbars are disabled. It gets aligned to the top left so is unusable on a screen that is shorter than ~600px since the buttons at the bottom are not displayed.
This change makes it so that the panel window will show scrollbars if necessary so that the ui component is usable on small displays.