Update Sign On Panel to collapse local login if SSO is enabled #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plessbd
added
enhancement
smgallo
suggested changes
Oct 15, 2018
smgallo
previously approved these changes
Oct 15, 2018
plessbd
force-pushed
the
sign-in-updates
branch
from
6daead6
to
9512b46
Compare
chakrabortyr
previously approved these changes
Oct 16, 2018
smgallo
suggested changes
Nov 16, 2018
configuration/portal_settings.ini
Outdated
| [sso] | ||
| ; used to show local sign in portion of the sign in modal | ||
| ; setting to true will show it. | ||
| show_local_login = "false" |
There was a problem hiding this comment.
All of the other entries in this file use on or off, we should be consistent.
There was a problem hiding this comment.
this just makes me want to change them all to true or false...
There was a problem hiding this comment.
Yeah, but then will all of the place where they're used still work or will you need to change all of them too.
plessbd
force-pushed
the
sign-in-updates
branch
from
a0af91d
to
b4f832f
Compare
chakrabortyr
previously approved these changes
Nov 19, 2018
smgallo
previously approved these changes
Nov 19, 2018
smgallo
approved these changes
Nov 19, 2018
chakrabortyr
approved these changes
Nov 19, 2018
chakrabortyr
approved these changes
Nov 19, 2018
smgallo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Force for the local login to be collapsed when using SSO with an option to not if provided.
Fix sign in form saving user and pass by browser when using local login.
Since I was already near some of the stuff in index.php I added a few new lines to make the javascript that is output a little cleaner.
Motivation and Context
Users and developers complained
Tests performed
Manually verified the outcome when SSO enabled and not and various combinations of portal setting
Types of changes