Adding Logging to Query.php #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a file logger to Query.php ( query.log ) - Added logic to the function 'execute' such that, when called and then 'sql_debug_mode' is true, the query that is about to be executed is logged.
smgallo
suggested changes
Mar 7, 2017
| @@ -229,6 +236,13 @@ public function execute($limit = 10000000) | |||
| { | |||
|
|
|||
| $query_string = $this->getQueryString($limit); | |||
|
|
|||
| $debug = filter_var(\xd_utilities\getConfiguration('general', 'sql_debug_mode'), FILTER_VALIDATE_BOOLEAN); | |||
There was a problem hiding this comment.
filter_var is broken in php 5.3 (which is our supported version). See issue #64 for a workaround. I have a function in the ETL\Utilities class but maybe it should be brought up into xd_utilities.
- Added a new 'filter_var' function to 'xd_utilities' that we can use to get around the limitations of the 'filter_var' implementation in PHP 5.3.x. - Updated the 'filter_var' usage in Query to utilize the new function in 'xd_utilities'.
smgallo
approved these changes
Mar 7, 2017
tyearke
added
enhancement
ryanrath
added a commit
to ryanrath/xdmod
that referenced
this pull request
Apr 27, 2017
* Adding Logging to Query.php - Added a file logger to Query.php ( query.log ) - Added logic to the function 'execute' such that, when called and then 'sql_debug_mode' is true, the query that is about to be executed is logged. * Updated per code review - Added a new 'filter_var' function to 'xd_utilities' that we can use to get around the limitations of the 'filter_var' implementation in PHP 5.3.x. - Updated the 'filter_var' usage in Query to utilize the new function in 'xd_utilities'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
'sql_debug_mode' is true, the query string that is about to be executed is logged.
Motivation and Context
It allows some visibility into the queries being generated / executed by the Query class.
Tests performed
Types of changes
Checklist: