Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure use of PHPUnit installed by composer #58

Merged
merged 1 commit into from
Feb 17, 2017

Conversation

jtpalmer
Copy link
Contributor

Description

Changes tests scripts so that they explicitly use the phpunit command installed by composer.

Motivation and Context

The travis scripts set the PATH to include the composer vendor directory, but there is no guarantee that a developer running the tests scripts will do the same or that they will not have a different version of PHPUnit installed elsewhere in their PATH. These changes ensure that the phpunit that is installed in the vendor directory will be used.

There may be a better way to do this, or we may not want to do it at all, so I'm open to discussion. I do think we should do something to make sure that it's easy for developers running these scripts on the command line to know the correct version of PHPUnit is being used.

Tests performed

Ran updated tests scripts on the command line.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added the enhancement Enhancement of the functionality of an existing feature label Feb 17, 2017
@jtpalmer jtpalmer added this to the v6.6.0 milestone Feb 17, 2017
Copy link
Contributor

@tyearke tyearke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Reducing the potential for inconsistency outweighs the convenience of using a global install, especially when obtaining the required version is just a one-line command.

Copy link
Member

@jpwhite4 jpwhite4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, we also need to make this change in all of the other sub module repositories too.

@jtpalmer jtpalmer merged commit 35f0c9a into ubccr:xdmod6.6 Feb 17, 2017
@jtpalmer jtpalmer deleted the use-composer-phpunit branch April 17, 2017 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants