Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Upgrades work again #453

Closed
wants to merge 1 commit into from
Closed

Conversation

plessbd
Copy link
Contributor

@plessbd plessbd commented Mar 5, 2018

I broke all the things...
my code is bad and I feel a tiny little bit maybe kinda sorta bad

/**
* @see \OpenXdmod\Migration\Migration::__construct
**/
public function __construct($currentVersion, $newVersion)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary? If no constructor is defined the next constructor up the chain should be called. Same thing for execute(). For example,

class Migrate
{
    public function __construct($currentVersion, $newVersion)
    {
        echo sprintf('%s::%s(%s, %s)', __CLASS__, __FUNCTION__, $currentVersion, $newVersion) . PHP_EOL;
    }
}

class M2 extends Migrate
{
}

$m = new Migrate(1, 2);
$m2 = new M2(2, 3);
smgallo@dave:~/tmp$ php test_parent_constructor.php 
Migrate::__construct(1, 2)
Migrate::__construct(2, 3)

@plessbd plessbd closed this Mar 5, 2018
ryanrath pushed a commit to ryanrath/xdmod that referenced this pull request Jan 15, 2021
…urce

- Updated the url for the TreeGrid to point at `/etl/pipelines/actions`
- Upated the `getActionsforPipelines` method chain so that it produces output
  suitable for use in an ExtJS TreeGrid.
  - The change @ ubccr#201 was needed due to `get_object_vars` returning a keyed
    array `<property> => <value>`.
  - ubccr#289: This function preps the output for use use in an EXtJS TreeGrid.
  - ubccr#453: This was simplify / declutter the display of the action name from it's
    fully qualified form `xdmod.pipeline.action` to `action` as the nodes
    immediately preceeding the action node will already be displaying the full
    pipeline name.
ryanrath pushed a commit to ryanrath/xdmod that referenced this pull request Jan 15, 2021
…urce

- Updated the url for the TreeGrid to point at `/etl/pipelines/actions`
- Upated the `getActionsforPipelines` method chain so that it produces output
  suitable for use in an ExtJS TreeGrid.
  - The change @ ubccr#201 was needed due to `get_object_vars` returning a keyed
    array `<property> => <value>`.
  - ubccr#289: This function preps the output for use use in an EXtJS TreeGrid.
  - ubccr#453: This was simplify / declutter the display of the action name from it's
    fully qualified form `xdmod.pipeline.action` to `action` as the nodes
    immediately preceeding the action node will already be displaying the full
    pipeline name.
ryanrath pushed a commit to ryanrath/xdmod that referenced this pull request Feb 25, 2021
…urce

- Updated the url for the TreeGrid to point at `/etl/pipelines/actions`
- Upated the `getActionsforPipelines` method chain so that it produces output
  suitable for use in an ExtJS TreeGrid.
  - The change @ ubccr#201 was needed due to `get_object_vars` returning a keyed
    array `<property> => <value>`.
  - ubccr#289: This function preps the output for use use in an EXtJS TreeGrid.
  - ubccr#453: This was simplify / declutter the display of the action name from it's
    fully qualified form `xdmod.pipeline.action` to `action` as the nodes
    immediately preceeding the action node will already be displaying the full
    pipeline name.
ryanrath pushed a commit to ryanrath/xdmod that referenced this pull request Mar 31, 2021
…urce

- Updated the url for the TreeGrid to point at `/etl/pipelines/actions`
- Upated the `getActionsforPipelines` method chain so that it produces output
  suitable for use in an ExtJS TreeGrid.
  - The change @ ubccr#201 was needed due to `get_object_vars` returning a keyed
    array `<property> => <value>`.
  - ubccr#289: This function preps the output for use use in an EXtJS TreeGrid.
  - ubccr#453: This was simplify / declutter the display of the action name from it's
    fully qualified form `xdmod.pipeline.action` to `action` as the nodes
    immediately preceeding the action node will already be displaying the full
    pipeline name.
ryanrath pushed a commit to ryanrath/xdmod that referenced this pull request Mar 31, 2021
…urce

- Updated the url for the TreeGrid to point at `/etl/pipelines/actions`
- Upated the `getActionsforPipelines` method chain so that it produces output
  suitable for use in an ExtJS TreeGrid.
  - The change @ ubccr#201 was needed due to `get_object_vars` returning a keyed
    array `<property> => <value>`.
  - ubccr#289: This function preps the output for use use in an EXtJS TreeGrid.
  - ubccr#453: This was simplify / declutter the display of the action name from it's
    fully qualified form `xdmod.pipeline.action` to `action` as the nodes
    immediately preceeding the action node will already be displaying the full
    pipeline name.
ryanrath pushed a commit to ryanrath/xdmod that referenced this pull request Jul 2, 2021
…urce

- Updated the url for the TreeGrid to point at `/etl/pipelines/actions`
- Upated the `getActionsforPipelines` method chain so that it produces output
  suitable for use in an ExtJS TreeGrid.
  - The change @ ubccr#201 was needed due to `get_object_vars` returning a keyed
    array `<property> => <value>`.
  - ubccr#289: This function preps the output for use use in an EXtJS TreeGrid.
  - ubccr#453: This was simplify / declutter the display of the action name from it's
    fully qualified form `xdmod.pipeline.action` to `action` as the nodes
    immediately preceeding the action node will already be displaying the full
    pipeline name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants