Travis: Manually update Composer when automatic update fails #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smgallo
approved these changes
Jan 20, 2017
Merged
This was referenced Jan 20, 2017
|
Please do not forget to check whether changes to the travis code are also needed in the XDMoD sub modules. The code is very similar, which makes it likely that an error in one also affects the other. |
|
Also don't forget that the lock files needed to updated too when you update composer. and this needs to happen in all of the sub-modules that also need the self-update commands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes a case where Travis CI was not updating Composer to the latest stable version, causing builds with newer Composer config files to fail.
Motivation and Context
When Travis attempts to automatically update Composer to the latest version while using PHP 5.3.3, it fails because of SSL issues with Travis systems using PHP 5.3.3. This meant that tests were done using the pre-installed version of Composer, 1.0.0. This now presents a problem, as newer versions of Composer have introduced backwards-incompatible changes to the lock file format.
Tests performed
I ran the updated Travis scripts with pushes on my fork. The results may be found here.
Types of changes
Checklist:
I have added tests to cover my changes.