Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relocated string to config #213

Merged
merged 2 commits into from
Aug 9, 2017
Merged

relocated string to config #213

merged 2 commits into from
Aug 9, 2017

Conversation

jpearce185
Copy link
Contributor

Description

I took the hard coded signature string of the project team and moved it into the config.

Motivation and Context

This signature can now be used in more than one place without having to be hard coded, and reduces the amount of hard coded values.

Tests performed

I sent completed contact forms via email with the signature coming from the config rather than using a hard coded value.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jpwhite4
Copy link
Member

jpwhite4 commented Aug 9, 2017

For consistency with the rest of XDMoD and to match the documentation in portal_settings.ini, I suggest that you use the MailTemplates::getMaintainerSignature() function since this includes the logic that sets the signature to the origanization name if the maintainer_email_signature setting is absent.

@jpwhite4
Copy link
Member

jpwhite4 commented Aug 9, 2017

Please squash and merge rather than merge.

@jpwhite4 jpwhite4 merged commit ac5d126 into ubccr:xdmod7.0 Aug 9, 2017
@tyearke tyearke added the enhancement Enhancement of the functionality of an existing feature label Aug 14, 2017
@tyearke tyearke added this to the v7.0.0 milestone Aug 14, 2017
ryanrath pushed a commit to ryanrath/xdmod that referenced this pull request Sep 18, 2017
* string moved into config

* changes
chakrabortyr pushed a commit to chakrabortyr/xdmod that referenced this pull request Oct 17, 2017
* string moved into config

* changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants