Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing name of Utilization metric to CPU Utilization #1898

Merged
merged 8 commits into from
Aug 21, 2024
Merged

Changing name of Utilization metric to CPU Utilization #1898

merged 8 commits into from
Aug 21, 2024

Conversation

eiffel777
Copy link
Contributor

Change the name of the Utilization metric to CPU Utilization as it is more accurate. Updated tests with the new name.

Tests performed

Tested in docker

Checklist:

  • The pull request description is suitable for a Changelog entry
  • The milestone is set correctly on the pull request
  • The appropriate labels have been added to the pull request

@eiffel777 eiffel777 added the Category:General General label Aug 15, 2024
@eiffel777 eiffel777 added this to the 11.0.0 milestone Aug 15, 2024
@eiffel777 eiffel777 self-assigned this Aug 15, 2024
aaronweeden
aaronweeden requested changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@aaronweeden aaronweeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gateways realm also needs updating.

@aaronweeden
Copy link
Contributor

configuration/etl/etl_data.d/xdb/report-template-charts.json has some charts with names that should perhaps be changed from Percent Utilization to Percent CPU Utilization.

@eiffel777
Copy link
Contributor Author

eiffel777 commented Aug 19, 2024 •
edited
Loading

Gateways realm also needs updating.

configuration/etl/etl_data.d/xdb/report-template-charts.json has some charts with names that should perhaps be changed from Percent Utilization to Percent CPU Utilization.

These are both done now.

ryanrath
ryanrath previously approved these changes Aug 21, 2024
View reviewed changes
aaronweeden
aaronweeden previously approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@aaronweeden aaronweeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming we don't want to change the names of charts in users' existing reports in the report generator? If so, looks good.

@eiffel777 eiffel777 dismissed stale reviews from aaronweeden and ryanrath via 4ec4ad1 August 21, 2024 15:31
@eiffel777 eiffel777 merged commit b8ff936 into ubccr:xdmod11.0 Aug 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronweeden aaronweeden aaronweeden approved these changes

@ryanrath ryanrath ryanrath left review comments

@jpwhite4 jpwhite4 Awaiting requested review from jpwhite4

@connersaeli connersaeli Awaiting requested review from connersaeli

@aestoltm aestoltm Awaiting requested review from aestoltm

Assignees

@eiffel777 eiffel777

Labels
Category:General General
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@eiffel777 @aaronweeden @ryanrath