Fix Migration Class Warning Generation #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bit of code is being told to process not-files on PHP 7.4 AppKernels. So adding a quick check to make sure that the fd actually points to a file before processing will make it so those error messages aren't generated.
ryanrath
force-pushed
the
fix-aStructuredFile
branch
from
b214356
to
3dfd099
Compare
ryanrath
requested review from
eiffel777,
jpwhite4,
aaronweeden,
connersaeli and
aestoltm
ryanrath
changed the title
eiffel777
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This code was causing warnings to be generated when testing with PHP 7.4. It turns out that trying to create a
Configurationobject for an entire directory will do that. Upon further investigation I found that the only time this property was used was to access it'sbaseDirvalue ( Which is always equal to theCONFIG_DIRclass constant). I just updated the uses of this property to instead useCONFIG_DIRand removed the now unusedconfigproperty.Motivation and Context
Less warnings == less support tickets.
Tests performed
Checklist: