Updating PHPUnit Test that should have been updated in the PHP 7.4 merge. #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronweeden
requested changes
Jun 20, 2024
tests/unit/lib/ETL/Configuration/JsonReferenceWithFallbackTest.php
Outdated
Show resolved
Hide resolved
tests/unit/lib/ETL/Configuration/JsonReferenceWithFallbackTest.php
Outdated
Show resolved
Hide resolved
tests/unit/lib/ETL/Configuration/JsonReferenceWithFallbackTest.php
Outdated
Show resolved
Hide resolved
….php Co-authored-by: Aaron Weeden <31246768+aaronweeden@users.noreply.github.com>
….php Co-authored-by: Aaron Weeden <31246768+aaronweeden@users.noreply.github.com>
….php Co-authored-by: Aaron Weeden <31246768+aaronweeden@users.noreply.github.com>
aaronweeden
approved these changes
Jun 21, 2024
ShixinWu16
pushed a commit
to ShixinWu16/xdmod
that referenced
this pull request
Jul 2, 2024
…rge. (ubccr#1873) * Missed this somehow * Update tests/unit/lib/ETL/Configuration/JsonReferenceWithFallbackTest.php Co-authored-by: Aaron Weeden <31246768+aaronweeden@users.noreply.github.com> * Update tests/unit/lib/ETL/Configuration/JsonReferenceWithFallbackTest.php Co-authored-by: Aaron Weeden <31246768+aaronweeden@users.noreply.github.com> * Update tests/unit/lib/ETL/Configuration/JsonReferenceWithFallbackTest.php Co-authored-by: Aaron Weeden <31246768+aaronweeden@users.noreply.github.com> --------- Co-authored-by: Aaron Weeden <31246768+aaronweeden@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Not exactly sure how this was missed, but it was.
Motivation and Context
Tests performed
Checklist: