Fixing Token Header Auth #1863
Merged
Fixing Token Header Auth #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it looks like Silex removes the `Authorization` header for some reason so I've added a fall back of checking the results of the PHP built in function `getallheaders`. I also added a couple of comments to help with reading things after the fact.
ryanrath
added
Category:Infrastructure
eiffel777
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getallheaders()for the presence of theAuthorizationheader due to Silex seeming to remove the header ( or at least it's not present when usingrequest->headers->[all()|get()|has()]Motivation and Context
So it looks like Silex removes the
Authorizationheader for some reason so I've added a fall back of checking the results of the PHP built in functiongetallheaders.I also added a couple of comments to help with reading things after the fact.
Tests performed
Automated Tests.
Checklist: