Update description of Job Size: Normalized statistic #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiffel777
added
documentation
eiffel777
requested review from
jpwhite4,
ryanrath,
aaronweeden,
connersaeli and
aestoltm
jpwhite4
reviewed
May 22, 2024
Co-authored-by: Joe White <jpwhite4@buffalo.edu>
aaronweeden
reviewed
May 28, 2024
| @@ -121,7 +121,7 @@ | |||
| "aggregate_formula": { | |||
| "$include": "datawarehouse.d/include/Jobs-norm-avg-proc-agg.sql" | |||
| }, | |||
| "description_html": "The percentage average size ${ORGANIZATION_NAME} job over total machine cores.<br><i>Normalized Job Size: </i>The percentage total number of processor cores used by a (parallel) job over the total number of cores on the machine.", | |||
| "description_html": "The average size ${ORGANIZATION_NAME} job divided by the total number of cores in the resource where the job ran. The job normalization calculation assumes that the resource size is constant. This statistic should not be used with a time range where the resource size changes, because the statistic will be incorrect.<br><i>Normalized Job Size: </i>The ratio of the total number of processor cores used by a (parallel) job over the total number of cores on the resource.", | |||
There was a problem hiding this comment.
It seems like "percentage" should be included since the formula multiplies by 100.
There was a problem hiding this comment.
Yes I missed that when I did my suggestion.
Updating statistic description
jpwhite4
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update description to include information about cases where the statistic is inaccurate.
Tests performed
Tested in docker
Checklist: