Change resource specs aggregation to better handle joins to modw.resource_allocated table #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiffel777
added
Category:ETL
eiffel777
requested review from
jpwhite4,
ryanrath,
aaronweeden,
connersaeli and
aestoltm
aaronweeden
requested changes
May 1, 2024
configuration/etl/etl_action_defs.d/resource_specifications/resource_specs_aggregation.json
Outdated
Show resolved
Hide resolved
...uration/etl/etl_action_defs.d/resource_specifications/resource_specs_aggregation_by_day.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Aaron Weeden <31246768+aaronweeden@users.noreply.github.com>
aaronweeden
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous join to
modw.resource_allocatedrelied on the fact that in Open XDMoD the start and end dates for a resource spec and resource allocated are the same. This is not the case for ACCESS XDMoD so this change instead joins using a date range to get an change in the resource allocated during the date range being allocated. The start and end dates frommodw.resource_allocatedare also used in the macro used to determine the time period used in calculating the various columns.Tests performed
Tested in docker and added an extra rows to
modw.resourcespecsandmodw.resource_allocatedto check that the new aggregation works. Below is a sql file that has an export of those tables with the extra rows that can be used to manually test that the aggregation works.resourcespecs_sql_dump.zip
Checklist: